Review 12.4 Merged

81669[BUGFIX] Keep ValuePicker in sync with field value for replace mode

Oli Bartsch CR +2 V +2 Normal +40 −12 updated 11/15/23, 15:25

Commit message

A "valuePicker" TCA configuration allows to either prepend, append or
replace a preset for an input field.

While "prepend" and "append" allow to continuously pick and choose
elements to be inserted, the "replace" mode is single-use and always
resets to a single chosen value.

For the "replace" mode it could be helpful to keep the input field
in sync with the ValuePicker especially if the value picker as a
human-readable representation of the value that is added in the
input field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 11/15/23, 15:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/15/23, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48959

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 11/15/23, 15:25

  4. Oli Bartsch merged patch set 2 11/15/23, 15:25