81730[BUGFIX] hide "Add content"-button in localization "connected mode"
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/81730/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/81730/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 2
Issues 1
Files 1
Review log 1013
-
Ayke Halder uploaded patch set 1 11/13/23, 19:53
-
core-ci voted on patch set 1 V +1 11/13/23, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48872
-
Oliver Hader updated the commit message in patch set 2
V +110/18/24, 14:08 -
Oliver Hader rebased onto patch set 3 11/15/24, 08:43
-
core-ci voted on patch set 3 V +1 11/15/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69463
-
Oli Bartsch commented on patch set 3 V -1 11/15/24, 13:06
As per documentation (https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/Mod/WebLayout.html#mod-web-layout-localization-enableCopy, https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/Mod/WebLayout.html#mod-web-layout-localization-enableTranslate) those options only target the translation wizard options and not the translation workflow in general. Therefore, adding content to a not yet translated page should always be possible. Additionally, - when looking at the report - rendering the "connected mode" badge for a not yet translated page is just wrong as this state describes the relation of content elements to their parent (if there is a parent at all). So this state can not be defined as long as there is not a single element present. Especially not "connected mode", because this requires at least one element, having a localization parent. -
Ayke Halder commented on patch set 3 11/15/24, 13:29
Reply
Not fixing this issue results in a real dead-lock for editors - see issue description: https://forge.typo3.org/issues/102369 Any idea how to deal with this deadlock - in case this patch is not applied? -
Oli Bartsch commented on patch set 3 11/15/24, 13:49
Reply
What is the dead-lock in this case? -
Ayke Halder commented on patch set 3 11/15/24, 14:01
Reply
The dead-lock is that the "translation"-button and -dialogue does not work anymore. Plus the message shown to the user does not help in any way to solve the situation. https://forge.typo3.org/issues/102369#Steps-to-reproduce -
Oli Bartsch commented on patch set 3 11/15/24, 20:31
Reply Unresolved
What situation should be resolved? The current behaviour seems to be completely fine. In case a user manually creates a content on a localized page => this page is in "free mode". If only "translation" is enabled in the translation wizard => no option is available => user is informed about this. I admit we could optimize the current message in this regard. Or maybe hide the button completely. But this I don't see any misbehaviour here and no dead-lock. Content can be created as usual, only the translation wizard is not available. -
Benni Mack updated the commit message in patch set 4
V +104/22/26, 06:25 -
core-ci voted on patch set 4 V -1 04/22/26, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100689
-
Benni Mack commented on patch set 4 11/11/26, 11:00
Unresolved
this change needs to be re-done completely, as this logic now belongs in the Translation Wizard in v14. I suggest abandoning it and start from scratch