Review main Ready for review

93063[TASK] Show warnings on orphaned translations

Eric Harrer CR -1 V 0 Hard +414 −5 updated 11/13/26, 07:15

Commit message

Show specific badge warnings for translated content elements in the
layout module when their translation parent points to a missing
record, to a non-default language record or to a record in
language "All".

These invalid translation parent references are treated as
connected translations when determining the language mode and now
also trigger the generic stale translation flash message. Mixed
mode is still used only when standalone and connected
translations coexist for the same language on the page.

Functional tests cover all three invalid parent states. They
verify the warning labels, the stale translation flash message
and the language mode for both invalid parent references and
mixed translation setups.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/93063/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/93063/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Benni Mack -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 20

Issues 1

Files 5

Review log 1523

  1. Eric Harrer uploaded patch set 1 03/04/26, 13:37

  2. Eric Harrer updated the commit message in patch set 2 03/04/26, 13:41

  3. Eric Harrer updated the commit message in patch set 3 03/04/26, 13:44

  4. core-ci voted on patch set 3 V +1 03/04/26, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97325

  5. core-ci voted on patch set 1 V +1 03/04/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97323

  6. core-ci voted on patch set 2 V -1 03/04/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97324

  7. Eric Harrer rebased onto patch set 4 V +1 03/04/26, 19:31

  8. core-ci voted on patch set 4 V +1 03/04/26, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97359

  9. André Buchmann commented on patch set 4 CR -1 03/06/26, 21:46

    Suggestion: [TASK] Show warnings on orphaned translations
    layout module

    ContentFetcher.php:203

    As discussed: Do not activate the mixed mode, as it will enable the user to add more loose content elements. I reverted the condition and the warnings on the content elements still show up as expected.
  10. Eric Harrer uploaded patch set 5 CR -1 V +1 03/08/26, 12:02

  11. Eric Harrer commented on patch set 5 03/08/26, 12:06

    Reply

    Applied, thank you.

    Reply

    Adjusted. The commit message now consistently refers to the layout module, and the body was rewritten to describe the final behavior more precisely.

    ContentFetcher.php:203 Reply

    Done. Mixed mode is now only set for standalone and connected translations. Invalid translation parent references still dispatch the generic stale translation FlashMessage, but keep connected mode when no standalone translated content exists. I also extended the functional coverage to make the behavior explicit: - invalid parent reference: connected mode + generic stale translation FlashMessage - standalone and connected translations: mixed mode + generic stale translation FlashMessage - standalone content plus invalid parent reference: mixed mode + exactly one generic stale translation FlashMessage
  12. core-ci voted on patch set 5 V +1 03/08/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97571

  13. Oliver Klee voted on patch set 5 V +1 03/08/26, 18:03

  14. André Buchmann commented on patch set 5 CR +1 V +1 03/13/26, 11:14

    Thx for the last changes. LGTM
  15. Benni Mack updated the commit message in patch set 6 CR +1 V +1 04/22/26, 07:28

  16. Eric Harrer rebased onto patch set 7 04/23/26, 10:49

  17. core-ci voted on patch set 7 V +1 04/23/26, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101029

  18. André Buchmann voted on patch set 7 CR +1 V +1 04/23/26, 21:26

  19. Eric Harrer uploaded patch set 8 CR +1 V +1 08/28/26, 22:05

  20. core-ci voted on patch set 8 V +1 08/28/26, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107332

  21. Benni Mack uploaded patch set 9 V +1 11/11/26, 10:33

  22. core-ci voted on patch set 9 V +1 11/11/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114049

  23. Benni Mack commented on patch set 9 CR -1 11/13/26, 07:15

    I wouldn't do it like this. How about this approach: - DataHandler rejects switching a default-language record to -1 while it has translations, with a DataHandler functional test. This is small and closes the reproduction steps in the issue. - Make orphans a state of their own in the page module - Let FormEngine open an orphan - catch the missing parent so the editor can disconnect or reassign the record