93063[TASK] Show warnings on orphaned translations
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/93063/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/93063/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Benni Mack -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 20
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 96331[BUGFIX] Point localized workspace records to live records
- main 95475[WIP][FEATURE] Show all-language content in language comparison
- main 92705[BUGFIX] Only offer translations of records the user may localize
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 81730[BUGFIX] hide "Add content"-button in localization "connected mode"
- main 97165[FEATURE] Offer file and folder search options
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 93597[WIP] Dispatch fields
- main 96201[FEATURE] Introduce upload constraints for file uploads
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 94653[WIP] Record Identity
- main 83637[FEATURE] Add filter to selectCheckBox fields
- main 93528[WIP][TASK] Add new ce wrapper to contain element behavior
- main 91404[!!!][TASK] Remove re-login password popup functionality
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 76792[WIP][TASK] Move view switch in page module
- main 78198[WIP][TASK] Introduce resource move in filelist
Issues 1
Files 5
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+23 −2
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php2+44 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.fluid.html+1 −1
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+337 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+9 −0
Review log 1523
-
Eric Harrer uploaded patch set 1 03/04/26, 13:37
-
Eric Harrer updated the commit message in patch set 2 03/04/26, 13:41
-
Eric Harrer updated the commit message in patch set 3 03/04/26, 13:44
-
core-ci voted on patch set 3 V +1 03/04/26, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97325
-
core-ci voted on patch set 1 V +1 03/04/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97323
-
core-ci voted on patch set 2 V -1 03/04/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97324
-
Eric Harrer rebased onto patch set 4
V +103/04/26, 19:31 -
core-ci voted on patch set 4 V +1 03/04/26, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97359
-
André Buchmann commented on patch set 4 CR -1 03/06/26, 21:46
Suggestion: [TASK] Show warnings on orphaned translationslayout moduleContentFetcher.php:203As discussed: Do not activate the mixed mode, as it will enable the user to add more loose content elements. I reverted the condition and the warnings on the content elements still show up as expected. -
Eric Harrer uploaded patch set 5
CR -1V +103/08/26, 12:02 -
Eric Harrer commented on patch set 5 03/08/26, 12:06
Reply
Applied, thank you.Reply
Adjusted. The commit message now consistently refers to the layout module, and the body was rewritten to describe the final behavior more precisely.ContentFetcher.php:203ReplyDone. Mixed mode is now only set for standalone and connected translations. Invalid translation parent references still dispatch the generic stale translation FlashMessage, but keep connected mode when no standalone translated content exists. I also extended the functional coverage to make the behavior explicit: - invalid parent reference: connected mode + generic stale translation FlashMessage - standalone and connected translations: mixed mode + generic stale translation FlashMessage - standalone content plus invalid parent reference: mixed mode + exactly one generic stale translation FlashMessage -
core-ci voted on patch set 5 V +1 03/08/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97571
-
Oliver Klee voted on patch set 5 V +1 03/08/26, 18:03
-
André Buchmann commented on patch set 5 CR +1 V +1 03/13/26, 11:14
Thx for the last changes. LGTM -
Benni Mack updated the commit message in patch set 6
CR +1V +104/22/26, 07:28 -
Eric Harrer rebased onto patch set 7 04/23/26, 10:49
-
core-ci voted on patch set 7 V +1 04/23/26, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101029
-
André Buchmann voted on patch set 7 CR +1 V +1 04/23/26, 21:26
-
Eric Harrer uploaded patch set 8
CR +1V +108/28/26, 22:05 -
core-ci voted on patch set 8 V +1 08/28/26, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107332
-
Benni Mack uploaded patch set 9
V +111/11/26, 10:33 -
core-ci voted on patch set 9 V +1 11/11/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114049
-
Benni Mack commented on patch set 9 CR -1 11/13/26, 07:15
I wouldn't do it like this. How about this approach: - DataHandler rejects switching a default-language record to -1 while it has translations, with a DataHandler functional test. This is small and closes the reproduction steps in the issue. - Make orphans a state of their own in the page module - Let FormEngine open an orphan - catch the missing parent so the editor can disconnect or reassign the record