Review 12.4 Merged

81782[BUGFIX] Create symlinks for public assets with specific vendor names

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 11/20/23, 16:15

Commit message

When `composer install|dumpautoload` is performed, the
PackageArtifactBuilder inspects the list of all extensions, and
then creates symlinks to `Resources/Public` of each extension
into the `_assets` subdirectory.

This step could fail, when a vendor name ended on "ext".
A package in `vendor/superagency-next/myextension/Resources/Public`
would not have gotten symlinked, because "ext/myextension"
matches in this combination.

The fix is to check the directory for the actual pattern
of non-composer legacy installations (which is available as a constant).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 11/20/23, 15:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/20/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49151

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 11/20/23, 16:15

  4. Stefan Bürk merged patch set 2 11/20/23, 16:15