Review 12.4 Merged

81784[BUGFIX] Set DOM attributes to Page module columns with defLangBinding enabled

Oli Bartsch CR +2 V +2 Easy +10 −7 updated 11/21/23, 08:56

Commit message

The Page module loads a different partial to render its columns if
`defLangBinding` is enabled, that misses some DOM attributes required
for drag&drop handling.

This patch now adds the necessary attributes (data attributes, CSS
classes).

Also, to workaround a rendering issue, the page module now reloads
itself after dropping an element into a column.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Oli Bartsch commented on patch set 1 11/21/23, 08:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/21/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49199

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 11/21/23, 08:56

  4. Oli Bartsch merged patch set 2 11/21/23, 08:56