Review 12.4 Merged

82015[BUGFIX] Throw dedicated exception for invalid request URL on CLI

Oli Bartsch CR +2 V +2 Easy +37 −1 updated 11/29/23, 20:27

Commit message

Usage of ServerRequestFactory::fromGlobals() on
CLI is discouraged as the request url, used to
create the request is invalid, except the
$_SERVER variable is adjusted beforehand.

To properly inform the developer, a dedicated
exception is now being thrown, if in CLI context.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 11/29/23, 20:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/29/23, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50140

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/29/23, 20:26

  4. Oli Bartsch merged patch set 2 11/29/23, 20:27