Review 12.4 Merged

82021[TASK] Add request object to Canonical Tag generation link

Benni Mack CR +2 V +2 Normal +103 −5 updated 12/04/23, 18:19

Commit message

The PSR-14 ModifyUrlForCanonicalTagEvent was one of the first PSR-14
events to be added to TYPO3 Core, and was rather useless, as it
did not contain the context to deal with creating a URl for the
canonical tag.

In order to make it useful, some more information is added to
the Event object.

This is a pre-cursor for a breaking change, for issue #99807.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 12/04/23, 18:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/04/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50336

  3. Benni Mack voted on patch set 1 CR +2 V +2 12/04/23, 18:19

  4. Benni Mack merged patch set 2 12/04/23, 18:19