Review 12.4 Merged

82235[TASK] Ensure removing dangling images works with podman

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 12/19/23, 15:35

Commit message

The TYPO3 core `runTests.sh` contains the `-u` option to
update the images and remove dangling images. Providing
an image name and a `--filter` option is not supported
by podman:
 > Error: cannot specify an image and a filter(s)
 and has not been discovered yet in the TYPO3
core implementation yet.

Both container runtimes `docker` and `podman` support filtering images
using the `reference` filter option. Therefore, this change modifies
the dangling image removal to use multiple filters

To verify that filtering with two `--filter` options can be used with
podman and docker, the following commands can be executed to list the
set of local non-dangling images.

Note: This example uses `dangling=false` instead of
	  `dangling=true` (as in `runTests.sh`), since we expect
      most developers don't have dangling images yet.

> podman images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

> docker images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 12/19/23, 15:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/19/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50815

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 12/19/23, 15:35

  4. Stefan Bürk merged patch set 2 12/19/23, 15:35