82254[BUGFIX] Respect different shortcut settings in alternative languages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 911
-
Peter Kraume uploaded patch set 1 12/19/23, 08:42
-
core-ci voted on patch set 1 V -1 12/19/23, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50794
-
Stefan Bürk commented on patch set 1 01/06/24, 23:09
-
Garvin Hicking commented on patch set 1 01/08/24, 22:02
PageRepository.php:1116ReplyRelated: Does the patch intentionally only address v11? (where using TYPO3_REQUEST might not be as bad as when using it in "main"...?). The existing code looks similar in v12 so I'd guess that it would need fixing there too, and if it also bleeds over to main (couldn't check) then I agree with Stefan and TYPO3_REQUEST should be prevented clearly to align with the goals of v13. -
Peter Kraume commented on patch set 1 01/08/24, 22:08
PageRepository.php:1116ReplyThe patch is for v11 on purpose because in v12 the code and behaviour changed and I was not able to reproduce my problem there. I will try to come up with a solution for TYPO3_REQUEST. -
Stefan Bürk voted on patch set 1 CR -1 01/10/24, 00:33
-
Peter Kraume rebased onto patch set 2
CR -1V -101/25/24, 11:14 -
core-ci voted on patch set 2 V -1 01/25/24, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52157
-
Oliver Hader marked it work in progress 01/25/24, 12:03
-
Daniel Siepmann commented on patch set 2 03/06/24, 15:22
PageRepository.php:1116Reply UnresolvedFrom my understanding: The PageLinkBuilder initializes a custom instance of PageRepository without language context. That's probably why Peter fetched that information. -
Benni Mack abandoned the change 10/31/24, 14:44
I will abandon this change for v11, as we won't merge this into the public repo anymore, free v11.5 support ends today.
PageRepository.php:1116