Review 12.4 Merged

82314[TASK] Allow usage of symfony 7

Benni Mack CR +2 V +2 Hard +301 −300 updated 01/04/24, 13:42

Commit message

This change enables Symfony 7 in
addition to symfony 6 in TYPO3.

Symfony7 requires PHP 8.2, thus
is not installed by default for the
time being, as this change is also
allowed for TYPO3 v12 support when
running with PHP 8.2 and composer.

Used commands:

composer req -W \
 "symfony/config:^6.4 || ^7.0" \
 "symfony/console:^6.4 || ^7.0" \
 "symfony/dependency-injection:^6.4 || ^7.0" \
 "symfony/doctrine-messenger:^6.4 || ^7.0" \
 "symfony/expression-language:^6.4 || ^7.0" \
 "symfony/filesystem:^6.4 || ^7.0" \
 "symfony/finder:^6.4 || ^7.0" \
 "symfony/http-foundation:^6.4 || ^7.0" \
 "symfony/mailer:^6.4 || ^7.0" \
 "symfony/messenger:^6.4 || ^7.0" \
 "symfony/mime:^6.4 || ^7.0" \
 "symfony/options-resolver:^6.4 || ^7.0" \
 "symfony/property-access:^6.4 || ^7.0" \
 "symfony/property-info:^6.4 || ^7.0" \
 "symfony/rate-limiter:^6.4 || ^7.0" \
 "symfony/routing:^6.4 || ^7.0" \
 "symfony/uid:^6.4 || ^7.0" \
 "symfony/var-dumper:^6.4 || ^7.0" \
 "symfony/yaml:^6.4 || ^7.0"

 composer req --dev -W \
 "codeception/codeception:^5.0.13" \
 "codeception/module-filesystem:^3.0.1" \
 "friendsofphp/php-cs-fixer:^3.46" \
 "symfony/translation:^6.4 || ^7.0"

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 17

Review log 57

  1. Benni Mack commented on patch set 1 01/04/24, 11:54

    Cherry Picked from branch main. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/adminpanel/composer.json * typo3/sysext/extbase/composer.json * typo3/sysext/fluid/composer.json * typo3/sysext/form/composer.json * typo3/sysext/install/composer.json * typo3/sysext/redirects/composer.json * typo3/sysext/webhooks/composer.json
  2. core-ci voted on patch set 1 V -1 01/04/24, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51102

  3. Benni Mack uploaded patch set 2 V -1 01/04/24, 12:00

  4. Benni Mack marked it ready for review 01/04/24, 12:00

  5. core-ci voted on patch set 2 V +1 01/04/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51103

  6. Benni Mack voted on patch set 2 CR +2 V +2 01/04/24, 13:42

  7. Benni Mack merged patch set 3 01/04/24, 13:42