Review 12.4 Merged

82615[BUGFIX] Indexed Search: Only write internal log if `debugMode` is enabled

Andreas Kienast CR +2 V +2 Easy +5 −8 updated 01/24/24, 09:00

Commit message

The `Indexer` class from Indexed Search has an `internal_log` property
that's only accessed when `debugMode` is enabled.

However, the wrapper method `log_setTSlogMessage()` always writes into
the log, which doesn't make much sense. Said method now checks for
enabled debugging before writing into the log property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 01/24/24, 08:54

    Cherry Picked from branch main.
  2. Andreas Kienast voted on patch set 1 CR +2 V +2 01/24/24, 08:55

  3. core-ci voted on patch set 1 V +1 01/24/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52060

  4. Andreas Kienast merged patch set 2 01/24/24, 09:00