Review 12.4 Merged

82742[BUGFIX] Omit click menu on icons in `browse` mode

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 02/05/24, 09:10

Commit message

The element browsers, such as file browser,
folder browser or the create folder browser
are rendering the FileList in the `browse`
mode. In this case the context menu component
is not loaded. This is correct, since using
the context menu inside the modal would lead
to various side effects.

Because the JS component is not loaded for
mentioned reasons, wrapping the icons with
the click menu needs to be omitted. This
otherwise leads to further side effect,
e.g. loading a second folder tree in the
create folder browser.

Therefore, this change now omits wrapping
the icon with then click menu when the
Filelist is used in the `browse` mode.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 02/05/24, 08:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/05/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52705

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/05/24, 09:10

  4. Oli Bartsch merged patch set 2 02/05/24, 09:10