Review 12.4 Merged

82840[TASK] Fix acceptence tests window size with php-webdriver 1.15

Benjamin Franzke CR +2 V +2 Easy +12 −8 updated 02/08/24, 15:53

Commit message

The configured browser capabilities (`chromeOptions`) are passed by
`codeception/module-webdriver` to `php-webdriver` as is.
php-webdriver expects the PHP constant ChromeOptions::CAPABILITY to be
used instead of hardcoding any strings. Therefore php-webdriver 1.15
changed this constants value from `chromeOptions` to
`goog:chromeOptions` [1], which means that the option `chromeOptions`
is no longer respected and the configured window size (and the headless
flag) is ignored.

We now use the newer W3C webdriver comaptible `goog:chromeOptions`
option and define window size definition via codeception's respective
option `window_size` while we are at it.

[1] https://github.com/php-webdriver/php-webdriver/commit/235c2aa07

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1018

  1. Benjamin Franzke commented on patch set 1 02/08/24, 11:01

    Cherry Picked from branch main.
  2. Benjamin Franzke uploaded patch set 2 02/08/24, 11:04

  3. core-ci voted on patch set 1 V -1 02/08/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52889

  4. core-ci voted on patch set 2 V -1 02/08/24, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52891

  5. core-ci commented on patch set 2 02/08/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52891

  6. Stefan Bürk uploaded patch set 3 V -1 02/08/24, 11:37

  7. core-ci voted on patch set 3 V +1 02/08/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52897

  8. core-ci voted on patch set 2 V -1 02/08/24, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52891

  9. core-ci commented on patch set 3 02/08/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52898

  10. Benjamin Franzke voted on patch set 3 CR +1 V +1 02/08/24, 13:17

  11. Stefan Bürk updated the commit message in patch set 4 CR +1 V +1 02/08/24, 13:18

  12. Stefan Bürk updated the commit message in patch set 5 02/08/24, 13:19

  13. Benjamin Franzke voted on patch set 5 CR +1 V +1 02/08/24, 13:19

  14. core-ci voted on patch set 4 V +1 02/08/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52906

  15. core-ci voted on patch set 5 V +1 02/08/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52907

  16. Oliver Klee voted on patch set 5 CR +1 V +1 02/08/24, 14:00

  17. Stefan Bürk voted on patch set 5 CR +2 V +2 02/08/24, 15:53

  18. Stefan Bürk merged patch set 6 02/08/24, 15:53