Review 12.4 Merged

82989[TASK] Show sender email address for mailtest in ext:install

Oli Bartsch CR +2 V +2 Easy +6 −5 updated 02/21/24, 14:53

Commit message

In TYPO3 versions before v9, the mailtest showed the configured
sender email address. This has been removed due to a wrong fluid
variable usage with #88523

With this change, the sender email address is now shown again in
the mailtest. Additionally, a note is added to clarify, that not
receiving the test email could be due to spam filters or the
sender domain SPF settings.

The notice about the `defaultMailFromAddress` has been removed,
since it is already checked in `EnvironmentController`, that
the value is configured and a valid email address.

Finally, the fluid variable `queueIdentifier` introduced with
#100084 has been removed, since it is not used in the template.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 02/21/24, 14:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/21/24, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53427

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/21/24, 14:53

  4. Oli Bartsch merged patch set 2 02/21/24, 14:53