Review main Merged

83571[BUGFIX] Standardize search field and its search icon location

Simon Schaufelberger CR +2 V +2 Easy +16 −20 updated 04/20/24, 20:59

Commit message

Place the search icon on the right side of the input field.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Lisa Kreitz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Lisa Kreitz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Simon Schaufelberger uploaded patch set 1 03/22/24, 12:05

  2. core-ci voted on patch set 1 V +1 03/22/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54845

  3. Markus Klein voted on patch set 1 CR +1 03/27/24, 09:40

  4. Markus Klein updated the commit message in patch set 2 CR +1 V +1 03/28/24, 14:26

  5. Markus Klein voted on patch set 2 CR +1 V +1 03/28/24, 14:26

  6. core-ci voted on patch set 2 V +1 03/28/24, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55026

  7. Georg Ringer commented on patch set 2 03/29/24, 09:49

    would be great to have in this commit only those changes which are relevant not the whitespace changes. could you please adopt it?
  8. Riccardo De Contardi commented on patch set 2 V +1 03/30/24, 15:12

    to be consistent with other search form behavior on the backend, when you have performed a search and hover on the input field, the "x" icon should - remove the text searched (this is already done) - refresh the page (I mean reset the search)
  9. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 04/09/24, 19:11

  10. core-ci voted on patch set 3 V +1 04/09/24, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55633

  11. Benni Mack commented on patch set 3 CR +1 V +1 04/20/24, 20:53

    Reply

    Hey Riccardo, the "x" icon is a browser-specific functionality (from input type=search) and e.g. does not even work on Firefox. I think we should move this into a separate change, and streamline the logic of the "x" in all places. OK?
  12. Lisa Kreitz voted on patch set 3 CR +1 V +1 04/20/24, 20:58

  13. Benni Mack voted on patch set 3 CR +2 V +2 04/20/24, 20:59

  14. Benni Mack merged patch set 4 04/20/24, 20:59