Review main Merged

83580[FEATURE] Add RecordLinktype for Linkvalidator

Sybille Peters CR +2 V +2 Hard +607 −8 updated 09/25/26, 23:15

Commit message

Links to records of custom tables using the record link handler,
for example `t3://record?identifier=tx_news&uid=99`, have never been
validated. The former `LinkHandler` linktype, removed in TYPO3 v11,
only supported the legacy `record:` syntax, and `InternalLinktype`
only claims links to `pages` and `tt_content`, so all other record
links are ignored.

A new `record` linktype is added and enabled by default. It reports
records that do not exist, are deleted or (configurable via
`mod.linkvalidator.reportHiddenRecords`) are hidden, not yet started
or expired. Table and enable fields are resolved via the TCA schema
API. Links to a table which is not available, for example because no
link handler configuration resolves the identifier, are reported with
the table or link identifier.

Checking is limited to the database record. It does not verify that a
public URL can be generated or fetched. Record links inside RTE
fields are found thanks to the parser fix of #102468.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 16

Review log 3253

Show 1628 earlier messages
  1. Sybille Peters uploaded patch set 1 03/23/24, 16:00

  2. Sybille Peters wrote 03/23/24, 16:00

    Topic set to Linkvalidator
  3. Sybille Peters uploaded patch set 2 03/23/24, 16:04

  4. core-ci voted on patch set 1 V -1 03/23/24, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54884

  5. core-ci voted on patch set 2 V -1 03/23/24, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54885

  6. Sybille Peters uploaded patch set 3 V -1 03/23/24, 16:30

  7. Sybille Peters uploaded patch set 4 03/23/24, 16:30

  8. core-ci voted on patch set 3 V -1 03/23/24, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54887

  9. core-ci voted on patch set 4 V +1 03/23/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54888

  10. Sybille Peters uploaded patch set 5 V +1 03/26/24, 06:16

  11. core-ci voted on patch set 5 V +1 03/26/24, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54944

  12. Philipp Kitzberger commented on patch set 5 CR +1 V +1 04/17/24, 09:08

    With slight adjustments of the method signatures this patch works fine for 12 too.
  13. Chris Müller uploaded patch set 6 CR +1 V +1 05/02/24, 17:50

  14. core-ci voted on patch set 6 V +1 05/02/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57109

  15. Sybille Peters commented on patch set 7 V +1 05/04/24, 08:32

    Published edit on patch set 6.
  16. core-ci voted on patch set 7 V +1 05/04/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57203

  17. Sybille Peters rebased onto patch set 8 V +1 06/22/24, 05:03

  18. core-ci voted on patch set 8 V +1 06/22/24, 05:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60057

  19. Sybille Peters rebased onto patch set 9 V +1 08/27/24, 08:41

  20. core-ci voted on patch set 9 V +1 08/27/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64280

  21. Stefan Bürk updated the commit message in patch set 10 V +1 09/12/24, 02:33

  22. Stefan Bürk uploaded patch set 11 09/12/24, 02:35

  23. Stefan Bürk voted on patch set 11 CR -1 09/12/24, 02:35

  24. core-ci voted on patch set 10 V +1 09/12/24, 02:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65515

  25. core-ci voted on patch set 11 V +1 09/12/24, 02:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65516

  26. Stefan Bürk uploaded patch set 12 CR -1 V +1 09/13/24, 22:45

  27. core-ci voted on patch set 12 V +1 09/13/24, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65715

  28. Stefan Bürk uploaded patch set 13 V +1 09/13/24, 22:58

  1. core-ci voted on patch set 13 V +1 09/13/24, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65716

  2. Benni Mack uploaded patch set 14 V +1 08/15/25, 13:12

  3. core-ci voted on patch set 14 V -1 08/15/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83458

  4. Benni Mack commented on patch set 14 08/15/25, 14:12

    do we still need this change?
  5. Sybille Peters commented on patch set 14 08/16/25, 11:37

    Reply

    Probably yes. I don't remember why I made it a WIP. There are todos in the commit. You can check if it is still required by trying to check custom record links. I am not very motivated right now, I am tied up in other issues (mostly external link checking) with brofix. Sorry.
  6. Benni Mack marked it work in progress 04/21/26, 14:57

  7. Benni Mack wrote 04/21/26, 14:57

    Removed cc Benni Mack.
  8. Benni Mack uploaded patch set 15 V -1 09/23/26, 16:25

  9. core-ci voted on patch set 15 V -1 09/23/26, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109089

  10. Benni Mack uploaded patch set 16 V -1 09/23/26, 17:15

  11. core-ci voted on patch set 16 V -1 09/23/26, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109095

  12. Benni Mack rebased onto patch set 17 V -1 09/24/26, 04:44

  13. Benni Mack commented on patch set 17 CR +1 V +1 09/24/26, 04:45

    This change is ready for review.

    Reply

    Done
  14. core-ci voted on patch set 17 V -1 09/24/26, 04:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109138

  15. Benni Mack uploaded patch set 18 CR +1 V +1 09/25/26, 17:17

  16. core-ci voted on patch set 18 V -1 09/25/26, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109280

  17. Benni Mack uploaded patch set 19 V -1 09/25/26, 17:53

  18. core-ci voted on patch set 19 V -1 09/25/26, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109284

  19. Stefan Bürk uploaded patch set 20 V -1 09/25/26, 20:43

  20. core-ci voted on patch set 20 V +1 09/25/26, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109305

  21. Stefan Bürk uploaded patch set 21 V +1 09/25/26, 21:31

  22. core-ci voted on patch set 21 V +1 09/25/26, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109306

  23. Stefan Bürk voted on patch set 21 CR +1 V +1 09/25/26, 22:03

  24. Benni Mack voted on patch set 21 CR +2 V +2 09/25/26, 23:15

  25. Benni Mack merged patch set 22 09/25/26, 23:15