#103403Make it possible to check custom record links with linkvalidator
Description
Currently, there is a known problem that RECORD link checking is not possible via the typolink_tag softref parser, see #102468. Because of this, when fixing this issue, one must currently test the record link checking using urls which are not wrapped in an a tag. This can be done for example, by using tt_content.header_link.
e.g. “t3://record?identifier=tx_news&uid=99999”
as described in https://docs.typo3.org/p/georgringer/news/main/en-us/Tutorials/BestPractice/Linkhandler/Index.html#linkhandler
Currently, InternalLinktype::checkLink is called for these types of links, but then it always evaluates to “true” if the target table is not “tt_content” or “pages”:
if (!in_array($table, ['pages', 'tt_content'], true)) {
return true;
}
Ideally, the InternalLinktype could handle custom records for other tables as well, e.g. tx_news_domain_model_news.
Reviews 2
Related issues 4
History 829
Show 4 earlier messages
-
Sybille Peters changed Related to #102468 <span data-processor="relativetime" data-value="2024-03-15T09:46:30+00:00" > 03/15/24, 09:46 </span>
-
Sybille Peters changed Related to #94086 <span data-processor="relativetime" data-value="2024-03-15T09:47:05+00:00" > 03/15/24, 09:47 </span>
-
Philipp Kitzberger commented <span data-processor="relativetime" data-value="2024-03-19T11:00:03+00:00" > 03/19/24, 11:00 </span>
-
Sybille Peters commented and changed assigned to Sybille Peters priority
Should haveMust have <span data-processor="relativetime" data-value="2024-03-20T10:26:42+00:00" > 03/20/24, 10:26 </span>You are right, it was removed. Thanks for pointing that out. As the author of that patch I feel responsible and will look into it.
- patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66265
- changelog: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.0/Breaking-92693-RemoveLinkHandlerLinktypeInLinkvalidator.html
I suspect the following (preliminary): At that time (v11.5), the InternalLinkType would have handled format like “t3://record?identifier=tx_news&uid=99999” and the handled format in LinkHandler was indeed obsolete. But in later versions, InternalLinktype handles only table pages and tt_content as mentioned above.
Unfortunately, we do not have tests for this and it is not documented very well, otherwise it might have been noticed earlier.
todos:
- check if this is working in v11
- check affected versions
- add functionality
- add testsHopefully, this can be backported as bugfix, otherwise have to find other solution, e.g. create external extension as supplement.
-
Sybille Peters changed Related to #92693 <span data-processor="relativetime" data-value="2024-03-23T07:43:02+00:00" > 03/23/24, 07:43 </span>
-
Sybille Peters changed description <span data-processor="relativetime" data-value="2024-03-23T15:11:32+00:00" > 03/23/24, 15:11 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 83580 status
NewUnder Review <span data-processor="relativetime" data-value="2024-03-23T16:00:02+00:00" > 03/23/24, 16:00 </span> -
Gerrit Code Review pushed patch set 2 for main to change 83580 <span data-processor="relativetime" data-value="2024-03-23T16:04:59+00:00" > 03/23/24, 16:04 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 83580 <span data-processor="relativetime" data-value="2024-03-23T16:30:09+00:00" > 03/23/24, 16:30 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 83580 <span data-processor="relativetime" data-value="2024-03-23T16:30:30+00:00" > 03/23/24, 16:30 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 83580 <span data-processor="relativetime" data-value="2024-03-26T06:16:14+00:00" > 03/26/24, 06:16 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 83580 <span data-processor="relativetime" data-value="2024-05-02T17:50:05+00:00" > 05/02/24, 17:50 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 83580 <span data-processor="relativetime" data-value="2024-05-04T08:32:11+00:00" > 05/04/24, 08:32 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 83580 <span data-processor="relativetime" data-value="2024-06-22T05:03:08+00:00" > 06/22/24, 05:03 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 83580 <span data-processor="relativetime" data-value="2024-08-27T08:41:53+00:00" > 08/27/24, 08:41 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 83580 <span data-processor="relativetime" data-value="2024-09-12T02:33:09+00:00" > 09/12/24, 02:33 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 83580 <span data-processor="relativetime" data-value="2024-09-12T02:35:31+00:00" > 09/12/24, 02:35 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 83580 <span data-processor="relativetime" data-value="2024-09-13T22:45:03+00:00" > 09/13/24, 22:45 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 83580 <span data-processor="relativetime" data-value="2024-09-13T22:58:38+00:00" > 09/13/24, 22:58 </span>
-
Sybille Peters changed Related to #106661 <span data-processor="relativetime" data-value="2025-05-07T08:18:07+00:00" > 05/07/25, 08:18 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 83580 <span data-processor="relativetime" data-value="2025-08-15T13:12:56+00:00" > 08/15/25, 13:12 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-23T16:26:00+00:00" > 09/23/26, 16:26 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-23T17:15:48+00:00" > 09/23/26, 17:15 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-24T04:44:55+00:00" > 09/24/26, 04:44 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-25T17:17:07+00:00" > 09/25/26, 17:17 </span>
-
Gerrit Code Review pushed patch set 19 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-25T17:53:59+00:00" > 09/25/26, 17:53 </span>
-
Gerrit Code Review pushed patch set 20 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-25T20:43:29+00:00" > 09/25/26, 20:43 </span>
-
Gerrit Code Review pushed patch set 21 for main to change 83580 <span data-processor="relativetime" data-value="2026-09-25T21:31:23+00:00" > 09/25/26, 21:31 </span>
-
Sybille Peters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-25T23:20:17+00:00" > 09/25/26, 23:20 </span>Applied in changeset commit:60f5841169181f3fbc419007b3422a91b081bcb4.
Prior to 11.0 those kinda links had been validated by EXT:linkvalidator/LinkType/Linkhandler which was removed with #92693”.
In those changelogs it says:
> The LinkHandler link type expects links which start with “record:” – a syntax that is now outdated.
but in Typolinks docs it still mentions that syntax.
Who’s right here? I kinda got the feeling that LinkType Linkhandler got removed a bit overhasty? Maybe renaming it to RecordLinkType would’ve been the more correct way to say goodbye to the old term “linkhandler”?