Review 12.4 Merged

83654[BUGFIX] Reinitialize ContentObjectRenderer for pages

Benni Mack CR +2 V +2 Easy +7 −1 updated 04/03/24, 10:21

Commit message

The menu generation must not reuse the page record from the current page
but must use the data from the linked page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack commented on patch set 1 04/03/24, 09:12

    Cherry Picked from branch main.
  2. Oliver Hader commented on patch set 1 04/03/24, 09:18

    AbstractMenuContentObject.php:1671

    Might the be other properties that are changed in the "sub-process" as well? What about `(clone $this->parent_cObj)->createLink(..)` instead?
  3. core-ci voted on patch set 1 V +1 04/03/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55217

  4. Benni Mack commented on patch set 1 04/03/24, 09:33

    AbstractMenuContentObject.php:1671 Reply

    as this is a straight backport, I would keep it as is (and we could create another patch)
  5. Oliver Hader commented on patch set 1 04/03/24, 10:12

    AbstractMenuContentObject.php:1671 Reply

    Fine. I was just going through open reviews and did not realized it's the back-port already. Fine then.
  6. Oliver Hader voted on patch set 1 CR +1 04/03/24, 10:12

  7. Benni Mack voted on patch set 1 CR +2 V +2 04/03/24, 10:21

  8. Benni Mack merged patch set 2 04/03/24, 10:21