83654[BUGFIX] Reinitialize ContentObjectRenderer for pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Benni Mack commented on patch set 1 04/03/24, 09:12
Cherry Picked from branch main. -
Oliver Hader commented on patch set 1 04/03/24, 09:18
AbstractMenuContentObject.php:1671Might the be other properties that are changed in the "sub-process" as well? What about `(clone $this->parent_cObj)->createLink(..)` instead? -
core-ci voted on patch set 1 V +1 04/03/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55217
-
Benni Mack commented on patch set 1 04/03/24, 09:33
AbstractMenuContentObject.php:1671Replyas this is a straight backport, I would keep it as is (and we could create another patch) -
Oliver Hader commented on patch set 1 04/03/24, 10:12
AbstractMenuContentObject.php:1671ReplyFine. I was just going through open reviews and did not realized it's the back-port already. Fine then. -
Oliver Hader voted on patch set 1 CR +1 04/03/24, 10:12
-
Benni Mack voted on patch set 1 CR +2 V +2 04/03/24, 10:21
-
Benni Mack merged patch set 2 04/03/24, 10:21