Review 12.4 Merged

83659[BUGFIX] Fix wrong GUI crop area placement on edge cases

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 04/04/24, 12:28

Commit message

In the image editor, the "Cropped area" was configured with a `ceil`ed
width and height. Since all other dimensions are `floor`ed, this might
cause an overlap.
Due to the configured cropping mode, defining that the cropping area
must never exceed the image dimensions, the cropper library places the
cropper to a position that's mathematically correct but not desired.

To solve this issue, the `width` and `height` properties fed to the
cropper are now `floor`ed as well, basically aligning with the rest of
the coordinates.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 04/04/24, 11:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/04/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55332

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 04/04/24, 11:54

  4. Andreas Kienast merged patch set 2 04/04/24, 12:28