Review 12.4 Merged

83753[TASK] Streamline Schema Parser test

Stefan Bürk CR +2 V +2 Hard +283 −254 updated 04/11/24, 10:39

Commit message

* Add variable names as dataprovider set
  array keys to increase readability.
* Add dataset for double-quote parsing in
  default values.
* Add a disabled dataset for single-quote
  parsing in default values with todo to
  enable it with the bugfix.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/11/24, 10:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/11/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55752

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/11/24, 10:39

  4. Stefan Bürk merged patch set 2 04/11/24, 10:39