Review 12.4 Merged

83754[TASK] Enable corrected test for default value parsing

Stefan Bürk CR +2 V +2 Easy +15 −15 updated 04/11/24, 18:43

Commit message

Test covering the SQL file parser has been streamlined
and enriched with #103602, adding a disabled test with
a todo to enable it when the SuT is fixed.

Turns out the parser already handles the case well,
the patch just enables the test.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Stefan Bürk commented on patch set 1 04/11/24, 18:32

    Cherry Picked from branch main.
  2. Stefan Bürk updated the commit message in patch set 2 04/11/24, 18:33

  3. core-ci voted on patch set 2 V +1 04/11/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55785

  4. core-ci voted on patch set 1 V +1 04/11/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55784

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 04/11/24, 18:43

  6. Stefan Bürk merged patch set 3 04/11/24, 18:43