Review 12.4 Merged

83892[BUGFIX] Guard nullable getNormalizedParams in getIpFunction

Nikita Hovratov CR +2 V +2 Easy +5 −1 updated 04/18/24, 06:04

Commit message

In case of CLI context, normalized params are not available and as they
are nullable, a guard condition is required before accessing methods.

Note: The access via request object was added in #100047 along with a
deprecation of using the ip() function in TSConfig. However, there is a
special case, where plain TypoScript is loaded even in CLI context. For
example this can happen when EXT:form listens to FlexForm data structure
parsing event. Then it needs information from TypoScript on how to
manipulate FlexForm based on YAML definitions.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 04/18/24, 05:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/18/24, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56213

  3. Nikita Hovratov voted on patch set 1 CR +2 V +2 04/18/24, 06:04

  4. Nikita Hovratov merged patch set 2 04/18/24, 06:04