Review 12.4 Merged

83895[BUGFIX] Check for children in FormEngine container

Oli Bartsch CR +2 V +2 Normal +28 −23 updated 04/19/24, 13:55

Commit message

When resolving the first and last inline
elements in the `FilesControlContainer`
and `InlineControlContainer`, it is now
properly checked, whether any children
exist at all, preventing possible type
errors.

Additionally a fallback is added to
prevent further warnings in the containers
while trying to iterate over the children.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 04/19/24, 13:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/19/24, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56343

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 04/19/24, 13:55

  4. Oli Bartsch merged patch set 2 04/19/24, 13:55