Review 12.4 Merged

83898[BUGFIX] Attach nonce attribute to script tag in admin panel's submodule

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 04/21/24, 19:17

Commit message

When providing a custom submodule for the admin panel with JavaScript,
the script tag does not have a nonce attribute attached. The $attributes
argument of the getAdditionalResourcesForModules() method holds a
"useNonce" configuration, which is now also passed to
getAdditionalResourcesForModules(), like for other calls in this
method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/21/24, 19:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/21/24, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56439

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/21/24, 19:17

  4. Stefan Bürk merged patch set 2 04/21/24, 19:17