Review 12.4 Merged

83979[BUGFIX] Mitigate invalid exit code for UpgradeWizard without updates

Stefan Bürk CR +2 V +2 Normal +127 −33 updated 04/23/24, 22:30

Commit message

Wizards not marked as done, but not having updates, display a
notice `No changes applied, marking wizard as done.` when using
the CLI command `bin/typo3 upgrade:run <wizard-identifier>` and
return an error exit code. This also happen when not specifying
a single wizard, but running all available ones.

The GUI based upgrade execution behaves different, as it does not
return an exit code and does not display information about
`no changes applied`, like its CLI counterpart.

This change:

* Adds new concrete exception classes for the `upgrade:run`
  command.

* Modifies `UpgradeWizardCommand::getUpgradeWizard()` to
  throw now one of the new concrete exception or return a
  wizard instance to run.

* Skips available upgrade wizards not eligible to be executed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk commented on patch set 1 04/23/24, 22:17

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/23/24, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56615

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/23/24, 22:30

  4. Stefan Bürk merged patch set 2 04/23/24, 22:30