Review 12.4 Merged

84274[BUGFIX] Avoid double-encoding of delete label

Andreas Kienast CR +2 V +2 Easy +16 −12 updated 05/14/24, 14:41

Commit message

The label for the delete action was encoded twice, leading to text
issues in case special characters are involved. This commit makes use of
`GeneralUtility::implodeAttributes()` to solve this issue properly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Andreas Kienast uploaded patch set 1 05/14/24, 13:33

  2. core-ci voted on patch set 1 V +1 05/14/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57711

  3. Andreas Kienast uploaded patch set 2 V +1 05/14/24, 13:44

  4. core-ci voted on patch set 2 V +1 05/14/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57713

  5. Andreas Kienast uploaded patch set 3 V +1 05/14/24, 13:56

  6. core-ci voted on patch set 3 V +1 05/14/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57717

  7. Andreas Kienast voted on patch set 3 CR +2 V +2 05/14/24, 14:40

  8. Andreas Kienast merged patch set 4 05/14/24, 14:41