Review 12.4 Merged

84353[TASK] Add some `ThumbnailViewHelper` functional tests

Anja Leichsenring CR +2 V +2 Normal +93 −0 updated 05/24/24, 12:58

Commit message

This change adds some tests for the `EXT:backend`
ThumbnailViewHelper, mainly to cover fix #102571.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Anja Leichsenring commented on patch set 1 05/22/24, 11:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 05/22/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58051

  3. Stefan Bürk commented on patch set 1 CR -2 05/22/24, 13:08

    Note: Leaving backport on hold for now - need to talk with Benni. Failure is related to changes in image processing behaviour between v12 and v13(main) and need to be discussed if intended or not. If intented, test expectation needs to get the adjusted height of `48`. Otherwise it indicates a bug either in v12 or v13.
  4. Stefan Bürk uploaded patch set 2 V -1 05/24/24, 08:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. Stefan Bürk commented on patch set 2 CR 0 05/24/24, 08:22

    Reply

    Adjusted test for now to match TYPO3 v12 behaviour. ImageProcessing difference with TYPO3 v13(main) needs more investigation and outside of this test backport change.
  6. core-ci voted on patch set 2 V +1 05/24/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58139

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 05/24/24, 12:58

  8. Stefan Bürk merged patch set 3 05/24/24, 12:58