Review 12.4 Merged

84357[TASK] Improve usability of user/group select in log module

Andreas Kienast CR +2 V +2 Easy +20 −17 updated 05/24/24, 13:25

Commit message

Instead of prefixing the type (user, group) for every option an optgroup
is used. With this change it is possible to use the keyboard to jump to
a specific letter.

Furthermore BackendUtility::getRecordTitle is used to retrieve the label
instead of using a hardcoded field name.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 05/24/24, 13:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/24/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58162

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 05/24/24, 13:25

  4. Andreas Kienast merged patch set 2 05/24/24, 13:25