Review 12.4 Merged

84362[TASK] Avoid implicitly nullable class method parameter

Stefan Bürk CR +2 V +2 Easy +10 −4 updated 05/27/24, 12:52

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is depreacted and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

In cases, where are implicitly nullable parameter exists
before not-nullable parameters in a method or constructor,
making it explicitly nullable will emit a

  Optional parameter <paramname> declared before required
  parameter <paramname> is implicitly treated as a required
  parameter

since PHP 8.0 [2].

This change adds the `?` nullable operator and removes the
null default value for the first parameter, which mitigates
both issues.

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
[2] https://php.watch/versions/8.0/deprecate-required-param-after-optional

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 05/27/24, 12:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/27/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58341

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 05/27/24, 12:52

  4. Stefan Bürk merged patch set 2 05/27/24, 12:52