Review main Merged

84452[BUGFIX] Perform is_dir without trailing slash

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 06/05/24, 15:02

Commit message

Workaround a PHP issue which will produce an open_basedir
restriction warning if `is_dir()` is used on a regular file
when the trailing slash is provided.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benjamin Franzke commented on patch set 1 05/28/24, 10:25

    Cherry Picked from branch 11.5.
  2. Benjamin Franzke commented on patch set 1 05/28/24, 10:31

    GeneralUtility.php:1658

    For reviewers, `is_dir` also works on symlinks without trailing slash: ``` php > var_dump(is_link('/home/ben/tmplink')); bool(true) php > var_dump(is_file('/home/ben/tmplink')); bool(false) php > var_dump(is_dir('/home/ben/tmplink')); bool(true) ```
  3. core-ci voted on patch set 1 V +1 05/28/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58390

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 06/05/24, 14:44

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 06/05/24, 14:48

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/05/24, 15:02

  7. Benjamin Franzke merged patch set 2 06/05/24, 15:02