84452[BUGFIX] Perform is_dir without trailing slash
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Benjamin Franzke commented on patch set 1 05/28/24, 10:25
Cherry Picked from branch 11.5. -
Benjamin Franzke commented on patch set 1 05/28/24, 10:31
GeneralUtility.php:1658For reviewers, `is_dir` also works on symlinks without trailing slash: ``` php > var_dump(is_link('/home/ben/tmplink')); bool(true) php > var_dump(is_file('/home/ben/tmplink')); bool(false) php > var_dump(is_dir('/home/ben/tmplink')); bool(true) ``` -
core-ci voted on patch set 1 V +1 05/28/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58390
-
Christian Kuhn voted on patch set 1 CR +1 V +1 06/05/24, 14:44
-
Stefan Bürk voted on patch set 1 CR +1 V +1 06/05/24, 14:48
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 06/05/24, 15:02
-
Benjamin Franzke merged patch set 2 06/05/24, 15:02