Review 12.4 Merged

84453[BUGFIX] Resolve falsy ENV-variables in YAML Site Configuration values

Stefan Bürk CR +2 V +2 Normal +57 −6 updated 05/29/24, 08:09

Commit message

Using '%env(SOME_VARIABLE)%' within a site configuration YAML
did not resolve contents in SOME_VARIABLE that were
falsy ('false', '0', 0).

This patch now properly converts those falsy values to actual
values.

Tests are added to verify the new behavior and prevent
future regressions. Drive-by fix on Unit tests which did
not actually remove env vars after testing, putenv('var')
is needed instead of putenv('var='), because the latter
will keep the environment var around (with an empty value).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 35

  1. Stefan Bürk commented on patch set 1 05/29/24, 07:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 05/29/24, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58436

  3. core-ci voted on patch set 1 V +1 05/29/24, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58436

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 05/29/24, 08:09

  5. Stefan Bürk merged patch set 2 05/29/24, 08:09