Review 12.4 Merged

84456[BUGFIX] Make DebuggerUtility UTF-8 aware for substring splitting

Benjamin Franzke CR +2 V +2 Normal +123 −4 updated 06/03/24, 07:48

Commit message

The current implementation does not properly split UTF-8 formatted
strings into multi-lines.

This patch now utilizes the corresponding mb_* PHP functions to ensure
proper splitting.

Tests are added to verify this behaviour.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Benjamin Franzke commented on patch set 1 05/30/24, 10:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 05/30/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58485

  3. core-ci commented on patch set 1 05/30/24, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58485

  4. Garvin Hicking commented on patch set 1 05/30/24, 14:54

    I think this happens because due to randomizing the tests it can happen that the stylesheet hasn't been emitted. I believe using this diff could make it work: ``` - $resultHtml = DebuggerUtility::var_dump($reallyLongInputWithUTF8, null, 8, false, false, true); + DebuggerUtilityAccessibleProxy::setStylesheetEchoed(true); + $resultHtml = DebuggerUtilityAccessibleProxy::var_dump($reallyLongInputWithUTF8, null, 8, false, false, true); ``` And I think that might also be applied to the "main" version of this patch?
  5. Benjamin Franzke uploaded patch set 2 V -1 05/31/24, 06:27

  6. Benjamin Franzke commented on patch set 2 05/31/24, 06:27

    Reply

    ack that looks like a side effect from `varDumpUsesNonceValue`, verified via: ``` Build/Scripts/runTests.sh -s unit -- --order-by=random --random-order-seed=1717071735 ``` I still wonder why it only happened in the random run…
  7. core-ci voted on patch set 2 V +1 05/31/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58521

  8. Benjamin Franzke commented on patch set 2 CR +2 V +2 05/31/24, 06:46

    Reply

  9. Benjamin Franzke merged patch set 3 06/03/24, 07:48