Review 12.4 Merged

84457[TASK] Remove unneeded `$siteMockRevelation` in SiteResolvingTest

Oli Bartsch CR +2 V +2 Easy +4 −6 updated 05/31/24, 06:51

Commit message

With migration away from prophecy during v12 development, the variable
`$siteMockRevelation` is not needed anymore as phpunit mocks don't know
the concept of revelations.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 05/31/24, 06:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/31/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58523

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 05/31/24, 06:51

  4. Oli Bartsch merged patch set 2 05/31/24, 06:51