Review 12.4 Merged

84554[TASK] Make cropper presets usable with keyboard

Georg Ringer CR +2 V +2 Easy +34 −8 updated 06/14/24, 20:18

Commit message

The aspect ratio buttons in the image cropping tool
have a visible focus state now to make them usable
when navigating with the keyboard tab key.

Additionally the button can now be pressed with
the space and return key.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 06/10/24, 18:18

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/10/24, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59070

  3. Georg Ringer voted on patch set 1 CR +2 V +2 06/14/24, 20:18

  4. Georg Ringer merged patch set 2 06/14/24, 20:18