84625[BUGFIX] Omit null attributes in media rendering
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php+5 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+5 −1
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+4 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+4 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-95714-NullAttributesAreOmittedInMediaRendering.rstnew+48 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+11 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+11 −0
Review log 1622
-
Georg Ringer uploaded patch set 1 06/11/24, 18:50
-
Georg Ringer commented on patch set 1 06/11/24, 18:50
This change is ready for review. -
core-ci voted on patch set 1 V -1 06/11/24, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59236
-
Georg Ringer commented on patch set 2
V -106/11/24, 18:57Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 06/11/24, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59237
-
Garvin Hicking commented on patch set 2 06/26/24, 20:37
I think this could cause trouble. Per spec (so I was told by some busy bee) a html5 definition of muted="muted", muted, muted="" would all be considered as "set". But this would then drop muted="" and be no longer set, which can have a breaking impact. Maybe in this case the default fluid templates of f:media would need to adopt putting "poster" into its own check, and only put it as an attribute when it exists? (Another sidenote, https://review.typo3.org/c/Packages/TYPO3.CMS/+/76103 seemy related and the solutions should ideally be aligned) -
Benni Mack updated the commit message in patch set 3
V +110/18/24, 13:36 -
core-ci voted on patch set 3 V -1 10/18/24, 22:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68000
-
Benni Mack commented on patch set 3 04/11/25, 21:59
Check out this one https://review.typo3.org/c/Packages/TYPO3.CMS/+/81763 -
Benni Mack wrote 04/21/26, 14:58
Removed cc Benni Mack. -
Benni Mack updated the commit message in patch set 4
V -104/22/26, 06:50 -
core-ci voted on patch set 4 V -1 04/22/26, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100813
-
Georg Ringer uploaded patch set 5
V -109/03/26, 18:17 -
core-ci voted on patch set 5 V +1 09/03/26, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107769
-
Garvin Hicking commented on patch set 5 CR +1 V +1 09/04/26, 06:25
Reply
Done -
Oliver Klee voted on patch set 5 CR +1 V +1 09/04/26, 06:37
-
Garvin Hicking commented on patch set 6
CR +1V +109/04/26, 06:49Published edit on patch set 5. -
Garvin Hicking voted on patch set 6 CR +1 V +1 09/04/26, 06:50
-
core-ci voted on patch set 6 V +1 09/04/26, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107812
-
Oliver Klee voted on patch set 6 CR +1 V +1 09/04/26, 07:49
-
Garvin Hicking voted on patch set 6 CR +2 V +2 09/04/26, 07:50
-
Garvin Hicking merged patch set 7 09/04/26, 07:50