Issue Bug Resolved

#95714Omit attributes with blank values for additionalAttributes in VideoTagRenderer

Christian Toffolo 10/20/21, 09:51 updated 09/04/26, 07:55

Description

VideoTagRenderer.php implodes attributes with $dontOmitBlankAttribs = true.

$attributes[] = GeneralUtility::implodeAttributes($options['additionalAttributes'], true, true);

This could create problems like in this use case:

Example:

<f:media ... additionalAttributes="{poster: '{v:media.exists(file: \'fileadmin/test.jpg\', then: \'/fileadmin/test.jpg\')}', no-cookie: 1, relatedVideos: 0, color: 'white', playsinline: '1'}" />

In this case, AFAIK, it’s not possible to omit the attribute ‘poster’ in Fluid. So, if file doesn’t exist the attribute will still be present with an empty value but the use case wants that if a poster is not available for the video then the attribute must not be present.

I don’t know if there are use cases that needs $dontOmitBlankAttribs = true but I think that it should be false.

Reviews 3

History 412

  1. Oliver Hader commented <span data-processor="relativetime" data-value="2021-10-20T13:28:15+00:00" > 10/20/21, 13:28 </span>

    Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/53488/, issue #81741
    (it probably affects some more classes, not only VideoTagRenderer)

  2. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-09-04T07:55:10+00:00" > 09/04/26, 07:55 </span>

    Applied in changeset commit:f6d7f90c0c7a8d3e94a19c73596c7de3ee456519.