Review 12.4 Merged

84632[TASK] Remove "Access for 'admin' users only!" hints in About module

Jasmina Ließmann CR +2 V +2 Easy +12 −12 updated 06/11/24, 13:10

Commit message

The "About" module lists, among other things, all backend modules
available in the system. If an admin or editor does not have access to
a module, it will not be displayed in the "About" module list.

Some of the modules listed contained a note that the module was only
accessible to administrators. With the introduction of the system
maintainer role, this note is no longer applicable. In addition, this
note was missing for some modules that cannot be made accessible to the
editor at all (e.g. "Access" module).

If an admin/system maintainer wants to check which backend modules an
editor can access, he usually switches to the backend user (via the
"Backend Users" backend module). Calling the "About" module is not
sufficient at this point, as settings in backend user groups and the
backend user accounts themselves also influence whether a backend user
can access a backend module or not.

For this reason, this note in the "About" module is now being removed.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 57

  1. Jasmina Ließmann commented on patch set 1 06/11/24, 13:00

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf
  2. Jasmina Ließmann uploaded patch set 2 06/11/24, 13:02

  3. Jasmina Ließmann marked it ready for review 06/11/24, 13:03

  4. core-ci voted on patch set 1 V +1 06/11/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59189

  5. core-ci voted on patch set 2 V +1 06/11/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59191

  6. Jasmina Ließmann voted on patch set 2 CR +2 V +2 06/11/24, 13:10

  7. Jasmina Ließmann merged patch set 3 06/11/24, 13:10