84638[TASK] Unify layout of SelectCheckBox group headers
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
-
Verified V +2 Done
- Andreas Nedbal +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_panel.scss+9 −0
- Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.ts+21 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+14 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.js+1 −1
Review log 68
-
Andreas Nedbal commented on patch set 1 06/13/24, 10:40
Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.ts * typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.js -
core-ci voted on patch set 1 V -1 06/13/24, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59459
-
Andreas Nedbal uploaded patch set 2
V -106/13/24, 10:57 -
Andreas Nedbal marked it ready for review 06/13/24, 10:57
-
core-ci voted on patch set 2 V +1 06/13/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59464
-
Jasmina Ließmann voted on patch set 2 V +1 06/13/24, 11:21
-
Andreas Nedbal voted on patch set 2 CR +2 V +2 06/13/24, 11:21
-
Andreas Nedbal merged patch set 3 06/13/24, 11:22