Review 12.4 Merged

84638[TASK] Unify layout of SelectCheckBox group headers

Andreas Nedbal CR +2 V +2 Normal +46 −6 updated 06/13/24, 11:22

Commit message

Before it was not really clear if/where a select check box header
was collapsible. This patch unifies the layout with the one of the
recordlist tables, adding a button specifically responsible to
collapse/expand the group.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Andreas Nedbal commented on patch set 1 06/13/24, 10:40

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.ts * typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.js
  2. core-ci voted on patch set 1 V -1 06/13/24, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59459

  3. Andreas Nedbal uploaded patch set 2 V -1 06/13/24, 10:57

  4. Andreas Nedbal marked it ready for review 06/13/24, 10:57

  5. core-ci voted on patch set 2 V +1 06/13/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59464

  6. Jasmina Ließmann voted on patch set 2 V +1 06/13/24, 11:21

  7. Andreas Nedbal voted on patch set 2 CR +2 V +2 06/13/24, 11:21

  8. Andreas Nedbal merged patch set 3 06/13/24, 11:22