84643[BUGFIX] Prevent rendering FlexForm diff of deleted records in history
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1217
-
Benni Mack commented on patch set 1 06/13/24, 17:42
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Functional/View/ValueFormatter/FlexFormValueFormatterTest.php -
Benni Mack commented on patch set 2 06/13/24, 17:43
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 06/13/24, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59523
-
core-ci voted on patch set 2 V -1 06/13/24, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59524
-
Georg Ringer commented on patch set 3
V -106/14/24, 20:20Published edit on patch set 2. -
Georg Ringer commented on patch set 3 06/14/24, 20:20
This change is ready for review. -
core-ci voted on patch set 3 V -1 06/14/24, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59618
-
Stefan Bürk commented on patch set 3 CR -1 06/17/24, 09:18
Seems some hickup with postgres - need to invest time to analyse this (unrelated to this change) due to deprecation in dbal, and why the sequence tables are not there and how to deal with that in general - and also how to get"upgrade" of id columns than backportet as this has only be added for the doctrine dbal 4 upgrade on main. This -1 for the backport for now. -
Georg Ringer rebased onto patch set 4
CR -1V -106/27/24, 15:34 -
core-ci voted on patch set 4 V -1 06/27/24, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60476
-
Stefan Bürk commented on patch set 4 06/27/24, 18:54
Reply
Rebasing this will not fix it magically. Have it on the list for tomorrow to debug it finally. -
Stefan Bürk uploaded patch set 5
V -106/30/24, 21:09 -
Stefan Bürk commented on patch set 5 06/30/24, 21:13
Reply
Should work now. `Connection->lastInsertId()` needs the tablename in v12 and Doctrine DBAL. That has changed in main with Doctrine DBAL 4, where lastInsertId() arguments have been removed and for PostgreSQL the autoincrement field handling has also changed. Thus slightly adjusting the test. TYPO3 API (DataHandler) uses lastInsertId() with tables usually. The old squence tables are made of the tablename and uid combination `tt_content_uid_seq` in this version, without the tablename the lastInsertId() override could not create the combined sequence table identifier. That means that only a testcase adoption has been needed for the backport. -
core-ci voted on patch set 5 V +1 06/30/24, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60710
-
Stefan Bürk voted on patch set 5 CR +1 V +1 06/30/24, 21:34
-
Georg Ringer voted on patch set 5 CR +2 V +2 07/01/24, 05:50
-
Georg Ringer merged patch set 6 07/01/24, 05:50