Review 12.4 Merged

84752[TASK] Replace invalid icon with working example

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 06/18/24, 07:09

Commit message

The backend layout wizard now uses a working example by using an
existing icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Garvin Hicking commented on patch set 1 06/18/24, 06:55

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js
  2. Garvin Hicking uploaded patch set 2 06/18/24, 07:02

    Fix merge conflict by rebuilding
  3. Garvin Hicking marked it ready for review 06/18/24, 07:02

  4. core-ci voted on patch set 1 V -1 06/18/24, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59780

  5. core-ci voted on patch set 2 V +1 06/18/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59781

  6. Georg Ringer voted on patch set 2 CR +2 V +2 06/18/24, 07:09

  7. Georg Ringer merged patch set 3 06/18/24, 07:09