Review 12.4 Merged

84759[BUGFIX] Improve and clean up Composer asset publishing

Garvin Hicking CR +2 V +2 Normal +144 −66 updated 06/20/24, 21:11

Commit message

The `PackageArtifactBuilder` takes care of publishing
`Resources/Public/...` directories of installed TYPO3 extensions
into the public directory.

In case this publishing fails, now a warning message is
presented, so that action can be taken.
Now also an info message is shown, when an extension does not
have a Resources/Public directory. This message is only shown
with increased verbosity, since this can be intentionally like so.

Further cleanup is preformed and code that does not apply any more
since composer installers v5 is required, is removed.

Last but not least, asset publishing is now decoupled into
a dedicated method, that receives installed packages as input
and returns resulting messages as output.

Future refactoring of the publishing code into a distinct
class is kept for a future change.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 06/20/24, 20:28

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php
  2. Garvin Hicking uploaded patch set 2 06/20/24, 20:33

    Resolve cherry pick merge conflict
  3. Garvin Hicking marked it ready for review 06/20/24, 20:33

  4. core-ci voted on patch set 1 V -1 06/20/24, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59946

  5. core-ci voted on patch set 2 V +1 06/20/24, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59947

  6. Georg Ringer voted on patch set 2 CR +2 V +2 06/20/24, 21:11

  7. Georg Ringer merged patch set 3 06/20/24, 21:11