Review 12.4 Merged

84837[BUGFIX] Properly show multiple cropping coverAreas per cropVariant

Andreas Nedbal CR +2 V +2 Easy +2 −2 updated 06/21/24, 09:58

Commit message

When switching between cropVariants with multiple coverAreas,
all of the previous coverAreas are properly removed, only
showing those that belong to a specific cropVariant.

See details and screenshots in the related ticket.

(A new styleguide TCA element crop_9 is also added
to showcase multiple coverAreas in multiple cropVariants)

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Nedbal commented on patch set 1 06/21/24, 09:41

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_imagemanipulation.php
  2. Andreas Nedbal uploaded patch set 2 06/21/24, 09:46

  3. Andreas Nedbal marked it ready for review 06/21/24, 09:46

  4. core-ci voted on patch set 1 V -1 06/21/24, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59986

  5. core-ci voted on patch set 2 V +1 06/21/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59987

  6. Andreas Nedbal voted on patch set 2 CR +2 V +2 06/21/24, 09:57

  7. Andreas Nedbal merged patch set 3 06/21/24, 09:58