Review 12.4 Merged

84844[TASK] Allow additional composer options for `-s composerInstall`

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 06/25/24, 08:54

Commit message

This change modifies the `Build/Script/runTests.sh`
command dispatcher to allow passing composer options
to the `composer install` subcommand, for example

  Build/Scripts/runTests.sh -s composerInstall \
    -- --prefer-source

Note that this is already possible using the generic
`-s composer` dispatcher but would resolve some user
confusion.

This is useful to install dependencies as git
checkouts, for example when working on packages
like `typo3/testing-framework` changes. Albeit
the need to remove the vendor folder first is
needed in case of the example.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/25/24, 08:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/25/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60275

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 06/25/24, 08:54

  4. Stefan Bürk merged patch set 2 06/25/24, 08:54