Review 12.4 Merged

84959[BUGFIX] Add `name` attribute to readonly fields in FormEngine

Oli Bartsch CR +2 V +2 Easy +21 −20 updated 06/28/24, 09:18

Commit message

Some FormEngine related JS components, e.g. the
slug element rely on input and text fields to
have the field name set via either the special
`data-formengine-input-name` - if pointing to
a hidden input field - or via the standard
`name` attribute.

All those FormEngine elements support the
readonly state, which renders only the field
with the `disabled` attribute set by omitting
any JS functionality. For this use case no
`name` attribute is required. However, to use
them in combination with other fields, e.g.
as generator field for TCA type slug, the
field name is now added as `name` attribute
in readonly state.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 34

  1. Oli Bartsch commented on patch set 1 06/28/24, 09:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/28/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60541

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 06/28/24, 09:18

  4. Oli Bartsch merged patch set 2 06/28/24, 09:18