Review main Merged

85108[TASK] Update list of devices for EXT:viewpage

Georg Ringer CR +2 V +2 Normal +50 −70 updated 12/19/24, 16:13

Commit message

We go away from an opinionated and notoriously outdated
vendor list to a list of "typical" resolutions as default
setup.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2633

Show 68 earlier messages
  1. Georg Ringer uploaded patch set 1 07/04/24, 20:41

  2. Georg Ringer commented on patch set 1 07/04/24, 20:41

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/04/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60988

  4. Oli Bartsch commented on patch set 1 07/05/24, 07:06

    In this step, could we also remove outdated devices?
  5. Benni Mack commented on patch set 1 07/05/24, 09:42

    Reply

    As this goes into 12.4 as well, I wouldn't do that. In contrast, I would rather suggest, to move the new list of items to the top of the list.
  6. Georg Ringer updated the commit message in patch set 2 V +1 07/10/24, 19:12

  7. Georg Ringer commented on patch set 2 07/10/24, 19:13

    Reply

    the items are sorted in viewpage again, the order in tsconfig doesn't matter. As there are some additional entries I thought 12.4 is fine but fine as well with having just in main - adopted the commit msg
  8. core-ci voted on patch set 2 V +1 07/10/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61329

  1. Benni Mack commented on patch set 2 CR +1 V +1 07/11/24, 12:00

    Reply

    Done
  2. Torben Hansen commented on patch set 2 07/11/24, 12:28

    As this is for main only now, I agree with Oli, that we should remove outdated devices. The dropdown list currently has 22 items.
  3. Christian Kuhn commented on patch set 2 CR -1 07/11/24, 12:38

    I would strongly recommend to go a step further: This list of arbitrary vendors is fishy, needs constant adaption and can never be complete. Let's remove them all and substitute them with some "typical" sets: 1-2 typical desktop resolutions, same for "pads" and same for "mobile". And that's it. If then some customer wants a special entry, it can be managed by agencies.
  4. Benni Mack commented on patch set 3 CR +1 V +1 07/11/24, 19:11

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V -1 07/11/24, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61411

  6. Christian Kuhn voted on patch set 3 CR -1 07/11/24, 19:21

  7. Christian Kuhn uploaded patch set 4 CR -1 V -1 12/19/24, 11:36

  8. Christian Kuhn commented on patch set 4 12/19/24, 11:36

    Reply

    Done
  9. core-ci voted on patch set 4 V -1 12/19/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71447

  10. Christian Kuhn uploaded patch set 5 V -1 12/19/24, 11:58

  11. Christian Kuhn uploaded patch set 6 12/19/24, 12:00

  12. core-ci voted on patch set 5 V +1 12/19/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71452

  13. core-ci voted on patch set 6 V +1 12/19/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71453

  14. Christian Kuhn voted on patch set 6 CR +1 V +1 12/19/24, 12:07

  15. Torben Hansen voted on patch set 6 CR +1 V +1 12/19/24, 12:22

  16. Jasmina Ließmann commented on patch set 6 12/19/24, 13:55

    locallang.xlf:21

    From what I see, this label is no longer used with this patch. Should we remove it?
  17. Christian Kuhn uploaded patch set 7 CR +1 V +1 12/19/24, 13:58

  18. Christian Kuhn commented on patch set 7 CR +1 V +1 12/19/24, 13:59

    locallang.xlf:21 Reply

    Done
  19. Jasmina Ließmann commented on patch set 6 12/19/24, 14:04

    locallang.xlf:21 Reply

    Hmm, and it seems to be the same with the following language keys? - width - tablet - customWidth - autoSize - automatic - unidentified
  20. Christian Kuhn commented on patch set 7 12/19/24, 14:06

    locallang.xlf:21 Reply

    unsure. i think removing those should then be a dedicated patch since it is unrelated to this change. is that ok with you?
  21. core-ci voted on patch set 7 V +1 12/19/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71455

  22. Jasmina Ließmann commented on patch set 7 CR +1 V +1 12/19/24, 14:09

    locallang.xlf:21 Reply

    Yes, ok.
  23. Benni Mack voted on patch set 7 CR +1 12/19/24, 15:47

  24. Christian Kuhn voted on patch set 7 CR +2 V +2 12/19/24, 16:13

  25. Christian Kuhn merged patch set 8 12/19/24, 16:13