Issue Task Closed

#100185Update device presets in view module

Florian Seirer 03/16/23, 12:26 updated 12/02/25, 14:33

Description

The device presets introduced in #77576 and defined in mod.web_view.previewFrameWidths are quite outdated and could use an update, especially the smartphones:
  • Nexus 6P (Released in 2015)
  • iPhone 7 Plus (Released in 2016)
  • iPhone 6
  • iPhone 5
  • iPhone 4

Reviews 2

Files 1

History 917

  1. Florian Seirer commented <span data-processor="relativetime" data-value="2023-03-16T14:03:54+00:00" > 03/16/23, 14:03 </span>

    To make the list more up to date without using actual device names the list could instead have resolutions/breakpoints used by popular devices like:
    • 1920 × 1080
    • 768 × 1024
    • 360 × 640
    • …

    I’m sure there are some statistics (Google Analytics?) out there with a list of the most used screen resolutions or breakpoints.

  2. Georg Ringer commented and changed status New Accepted <span data-processor="relativetime" data-value="2023-03-16T20:01:27+00:00" > 03/16/23, 20:01 </span>

    I suggest to remove outdated in main and just add additonal ones in 11.5

  3. Gerrit Code Review pushed patch set 1 for main to change 85108 status Accepted Under Review <span data-processor="relativetime" data-value="2024-07-04T20:41:20+00:00" > 07/04/24, 20:41 </span>

  4. Christian Kuhn changed attached Screenshot from 2024-12-19 12-37-25.png <span data-processor="relativetime" data-value="2024-12-19T11:37:44+00:00" > 12/19/24, 11:37 </span>

  5. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2024-12-19T16:15:08+00:00" > 12/19/24, 16:15 </span>

    Applied in changeset commit:63a4da4c23d4c8686d8f7b7438f466be63173bc2.