Review main Merged

85175[BUGFIX] Reinitialize ContentObjectRenderer for pages

Daniel Siepmann CR +2 V +2 Easy +5 −2 updated 07/09/24, 09:23

Commit message

The menu generation must not reuse the page record from the current page
but must use the data from the linked page.

This got already fixed for #101883.
But that fix didn't take into account that ->createLink() might throw an
exception. This is now considered and the state is properly
re- initialized also on exceptions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 811

  1. Daniel Siepmann uploaded patch set 1 07/09/24, 08:26

  2. Andreas Kienast commented on patch set 1 CR -1 07/09/24, 08:32

    AbstractMenuContentObject.php:1658

    The class misses the leading backslash. However, afaics, the catch() clause is superfluous and and be removed.
  3. core-ci voted on patch set 1 V -1 07/09/24, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61215

  4. Daniel Siepmann uploaded patch set 2 CR -1 V -1 07/09/24, 08:36

  5. Daniel Siepmann commented on patch set 2 07/09/24, 08:36

    AbstractMenuContentObject.php:1658 Reply

    Yes, tested and works without the catch. Thanks.
  6. core-ci voted on patch set 2 V +1 07/09/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61217

  7. Benni Mack updated the commit message in patch set 3 V +1 07/09/24, 08:47

  8. core-ci voted on patch set 3 V +1 07/09/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61219

  9. Benni Mack voted on patch set 3 CR +1 V +1 07/09/24, 08:53

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 07/09/24, 09:23

  11. Christian Kuhn merged patch set 4 07/09/24, 09:23