Review 12.4 Merged

85353[TASK] runTests.sh: Show phpstan memory consumption

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 07/25/24, 10:28

Commit message

phpstan can be very memory hungry. Option --verbose
adds a line about 'peak memory' usage to the output.
Add this to get a better feeling of the memory usage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Christian Kuhn commented on patch set 1 07/25/24, 08:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/25/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62158

  3. Christian Kuhn uploaded patch set 2 V +1 07/25/24, 09:08

  4. Mathias Brodala commented on patch set 2 07/25/24, 09:10

    Please make sure to refresh from main.
  5. core-ci voted on patch set 2 V -1 07/25/24, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62161

  6. Christian Kuhn updated the commit message in patch set 3 V -1 07/25/24, 09:59

  7. core-ci voted on patch set 3 V +1 07/25/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62165

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 07/25/24, 10:28

  9. Christian Kuhn merged patch set 4 07/25/24, 10:28