Review 12.4 Merged

85452[TASK] Ship optional upstream CKEditor5 plugins

Georg Ringer CR +2 V +2 Hard +202 −64 updated 08/01/24, 19:14

Commit message

With the CKEditor5 unbundling in #102099, we can now ship free (GPL-2
licensed) CKEditor5 modules, that may be useful, for some installations,
without the need to ship them for all installations in a big bundle.

  npm install --save \
        @ckeditor/ckeditor5-highlight@41.4.2 \
        @ckeditor/ckeditor5-language@41.4.2 \
        @ckeditor/ckeditor5-mention@41.4.2
  npm run build

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 3

Files 68

Show 48 more files

Review log 34

  1. Georg Ringer commented on patch set 1 08/01/24, 19:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/01/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62614

  3. Georg Ringer voted on patch set 1 CR +2 V +2 08/01/24, 19:14

  4. Georg Ringer merged patch set 2 08/01/24, 19:14