Review 12.4 Merged

85457[BUGFIX] Correctly infer site for new page

Andreas Kienast CR +2 V +2 Easy +23 −1 updated 08/03/24, 11:25

Commit message

SiteResolving will now correctly interpret a temporary ID of a new page (e.g., "NEW12345678ABCDEF") as an invalid ID and try to infer the site using `$result['effectivePid']`.

This makes it possible to access site configuration properties within the TCA also on pages that have yet to be created.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 08/03/24, 10:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/03/24, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62799

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 08/03/24, 11:24

  4. Andreas Kienast merged patch set 2 08/03/24, 11:25